Skip to content

Fix kernel download issues#8

Merged
facekapow merged 4 commits intomasterfrom
fix-kernel-download
Oct 4, 2015
Merged

Fix kernel download issues#8
facekapow merged 4 commits intomasterfrom
fix-kernel-download

Conversation

@facekapow
Copy link
Contributor

This PR fixes the kernel download issues (well, throws an informative error) when the module is installed globally and isn't run as root (but only when downloading). Fixes #5.

@iefserge
Copy link
Member

iefserge commented Oct 2, 2015

@ArielAbreu that's great! the only thing I think it feels a bit weird asking user for the root access just to download the file. Maybe we can simply fallback to the home directory like ~/.runtime?

@facekapow
Copy link
Contributor Author

How about using .runtime always? That way, you don't have to download it again for different projects.

@iefserge
Copy link
Member

iefserge commented Oct 3, 2015

@ArielAbreu sounds like a good idea 👍
maybe keep an optional local install as well? I guess it might be useful in some cases.

@facekapow
Copy link
Contributor Author

Added a --local option to save the kernel in the module's folder.

@iefserge
Copy link
Member

iefserge commented Oct 4, 2015

nice! one more thing to add https://github.com/runtimejs/runtime-tools/blob/fix-kernel-download/bin/runtime-qemu.js#L4 (so --local parsed as boolean)

@facekapow
Copy link
Contributor Author

Right, thanks!

@facekapow
Copy link
Contributor Author

OK to merge?

@iefserge
Copy link
Member

iefserge commented Oct 4, 2015

@ArielAbreu yeah, this is great! appreciate you fixing this!
this is going to be a major version because of new location for downloads

facekapow added a commit that referenced this pull request Oct 4, 2015
@facekapow facekapow merged commit a949e32 into master Oct 4, 2015
@facekapow facekapow deleted the fix-kernel-download branch October 4, 2015 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix runtimejs-kernels permission error

2 participants